Securing sensitive information in audit and history logs #11345

5 Answer(s)

• 

  0

  marble68 created 2 years ago

  After more digging - I apparently just need to replace the native EntityHistoryHelper with my own - but there's already a static object with the same name in the project in core project.

  I think it should be in the entityframeworkcore module - as that's where dbcontext lives.

  In the framework core, I have MyEntityHistoryHelper and everything looks good. In the entityframeworkcore module, I replace IEntityHistoryHelper with MyEntityHistoryHelper.

  Everything compiles and runs, but my entityhistoryhelper functions aren't called.

  Where do I do my configuration override?

  Save Cancel
• 

  0

  marble68 created 2 years ago

  Based on responses to other people, do we override the EntityHistoryHelper or EntityHistoryHelperBase?

  Save Cancel
• 

  0

  marble68 created 2 years ago

  Also asked for help here->

  https://support.aspnetzero.com/QA/Questions/9376/Save-Entity-History-for-only-record-update-and-delete-but-not-for-record-creation

  Save Cancel
• 

  0

  marble68 created 2 years ago

  I have this in the core project, which is a direct copy from abpzero project with no edits:

  using Abp.Domain.Uow;
  using Abp.EntityHistory;
  using Abp.EntityHistory.Extensions;
  using Abp.Events.Bus.Entities;
  using Abp.Extensions;
  using Abp.Json;
  using JetBrains.Annotations;
  using System;
  using System.Collections.Generic;
  using System.Data.Entity.Core;
  using System.Data.Entity.Core.Metadata.Edm;
  using System.Data.Entity.Core.Objects;
  using System.Data.Entity.Infrastructure;
  using System.Linq;
  using System.Reflection;
  using DbContext = System.Data.Entity.DbContext;
  using EntityState = System.Data.Entity.EntityState;
  using AbpEntityHistoryHelper = Abp.EntityHistory.EntityHistoryHelper;
  using System.Threading.Tasks;
  using System.Transactions;
  
  namespace mynamespace.EntityHistory
  {
      public class MyEntityHistoryHelper : AbpEntityHistoryHelper, IMyEntityHistoryHelper
      {
          public MyEntityHistoryHelper(IEntityHistoryConfiguration entityHistoryConfiguration, IUnitOfWorkManager unitOfWorkManager) : base(entityHistoryConfiguration, unitOfWorkManager)
          {
          }
  
          public EntityChangeSet CreateEntityChangeSet(DbContext context)
          {
              var changeSet = new EntityChangeSet
              {
                 .... code
  
              return changeSet;
          }
  
  
          public async Task SaveAsync(DbContext context, EntityChangeSet changeSet)
          {
             ... code
          }
  
          public void Save(DbContext context, EntityChangeSet changeSet)
          {
              ... code
          }
  
          [CanBeNull]
          protected virtual string GetEntityId(DbEntityEntry entityEntry, EntityType entityType)
          {
               ... code
          }
  
          [CanBeNull]
          private EntityChange CreateEntityChange(DbEntityEntry entityEntry, EntityType entityType)
          {
               ... code
          }
  
          private EntityType GetEntityType(ObjectContext context, Type entityType, bool useClrType = true)
          {
               ... code
          }
  
          private EntitySet GetEntitySet(ObjectContext context, EntityType entityType)
          {
               ... code
          }
  
          private static bool IsBaseTypeHasElementTypeName(string elementTypeName, EdmType entityEdmType)
          {
              ... code
          }
  
          /// <summary>
          /// Gets the property changes for this entry.
          /// </summary>
          private ICollection<EntityPropertyChange> GetPropertyChanges(DbEntityEntry entityEntry, EntityType entityType, EntitySet entitySet, bool auditedPropertiesOnly)
          {
               ... code
          }
  
          /// <summary>
          /// Gets the property changes for this entry.
          /// </summary>
          private ICollection<EntityPropertyChange> GetRelationshipChanges(DbEntityEntry entityEntry, EntityType entityType, EntitySet entitySet, ICollection<ObjectStateEntry> relationshipChanges, bool auditedPropertiesOnly)
          {
               ... code
          }
  
          /// <summary>
          /// Updates change time, entity id, Adds foreign keys, Removes/Updates property changes after SaveChanges is called.
          /// </summary>
          private void UpdateChangeSet(DbContext context, EntityChangeSet changeSet)
          {
              ... code
          }
  
          private EntityPropertyChange CreateEntityPropertyChange(object oldValue, object newValue, PropertyInfo propertyInfo)
          {
            ...
          }
  
  
      }
  }
  

  This is a copy of the EntityHistoryHelper in AspBoilderPlate.

  I put a break point on all public methods on the first line.

  Then, in every single PreInitialize method in the solution, I put the following as the very last command to try and ensure my custom entityhistoryhelper is used instead of the default.

  Configuration.ReplaceService<IEntityHistoryHelper, MyEntityHistoryHelper>(DependencyLifeStyle.Transient);
  

  I then edit an entity and Save, SaveAync, or CreateEntityChangeSet are not called.

  I've tried basing on EntityHistoryHelperBase as well.

  I'm obviously doing something wrong?

  Save Cancel
• 

  0

  marble68 created 2 years ago

  Update - I was finally able to resolve this. The solution was to ensure to use the core classes from ABP, and ensure to substitue in framework core.

  Save Cancel