Displaying modelstate errors #152

4 Answer(s)

• 

  0

  hikalkan created 9 years ago

  Support Team

  Hi,

  As I understood, you are building an MVC Action that returns JsonResult. In this methods you wanted to check ModelState and return a result containing validation errors. You can try this:

  You can directly return MvcAjaxResponse (<a class="postlink" href="https://github.com/aspnetboilerplate/aspnetboilerplate/blob/master/src/Abp.Web.Mvc/Web/Mvc/Models/MvcAjaxResponse.cs">https://github.com/aspnetboilerplate/as ... esponse.cs</a>) like that:

  return Json(new MvcAjaxResponse(...));
  

  MvcAjaxResponse contains Error property that you can use to set validation errors. There is not a built-in method to convert ModelState to MvcAjaxResponse, but you can write an extension method for that (if you then share this extension method, we can add it to ABP).

  Save Cancel
• 

  0

  hikalkan created 9 years ago

  Support Team

  It should be something like that:

  public static class ModelStateExtensions
      {
          public static MvcAjaxResponse ToMvcAjaxResponse(ModelStateDictionary modelState)
          {
              if (modelState.IsValid)
              {
                  return new MvcAjaxResponse();
              }
  
              var validationErrors = new List<ValidationErrorInfo>();
  
              foreach (var state in modelState)
              {
                  foreach (var error in state.Value.Errors)
                  {
                      validationErrors.Add(new ValidationErrorInfo(error.ErrorMessage, state.Key));
                  }
              }
  
              var errorInfo = new ErrorInfo(AbpWebLocalizedMessages.ValidationError)
                              {
                                  ValidationErrors = validationErrors.ToArray()
                              };
  
              return new MvcAjaxResponse(errorInfo);
          }
      }
  

  But I did not tested and checked what it builds. If you can test, please share results.

  Save Cancel
• 

  0

  nikko created 9 years ago

  Hello!

  I've tested it and it kind of works. I modified the code a bit just to compile:

  public static class ModelStateExtensions
      {
          public static MvcAjaxResponse ToMvcAjaxResponse(ModelStateDictionary modelState)
          {
              var validationErrors = new List<ValidationErrorInfo>();
  
              foreach (var state in modelState)
              {
                  foreach (var error in state.Value.Errors)
                  {
                      validationErrors.Add(new ValidationErrorInfo(error.ErrorMessage, new[] { state.Key }));
                  }
              }
  
              var errorInfo = new ErrorInfo("test")
              {
                  ValidationErrors = validationErrors.ToArray()
              };
  
              return new MvcAjaxResponse(errorInfo);
          }
      }
  

  Then i added some modelstate errors like:

  ModelState.AddModelError("Field1", "Field1 Invalid!");
  ModelState.AddModelError("", "Field Withname invalid!");
  

  The JSON that i get back looks like:

  {
    "targetUrl": null,
    "success": false,
    "result": null,
    "error": {
      "code": 0,
      "message": "test",
      "details": null,
      "validationErrors": [
        {
          "message": "Field1 Invalid!",
          "members": [
            "Field1"
          ]
        },
        {
          "message": "Field Withname invalid!",
          "members": [
            ""
          ]
        }
      ]
    },
    "unAuthorizedRequest": false
  }
  

  My question is how do i get validationErrors from the JSON when i need to override abp.message.error:

  abp.message.error = function(message, title) {
      // need to add my code to show the errors the way i want.
  }
  

  Thanks!

  Save Cancel
• 

  0

  hikalkan created 9 years ago

  Support Team

  Thanks for tests and informations. Follow <a class="postlink" href="https://github.com/aspnetboilerplate/aspnetboilerplate/issues/521">https://github.com/aspnetboilerplate/as ... issues/521</a> we can add it to ABP.

  Save Cancel