How involved would it be? Can you give a general direction on what would be needed?
@alexanderpilhar @ismcagdas
It seems to me that the onclose() only fires once and not again when connection.start() fails. This is using SignalR Core, is it supposed to fire onclose() again in signalr core?
Actually, I believe that the onClose event only fires if the connection actually successfully connected. So if the initial connection was successful but then closed, you will try to open the connection once but then never try again.
See better reconnection logic here from David Fowler: https://github.com/davidfowl/UT3/blob/dac409886c1bb7aec7c150b74d4ce9a3e246f03c/UTT/wwwroot/js/utt.js#L141-L153
@ismcagdas Wouldn't setInterval be needed to check every 5 seconds instead of setTimeout?
@ismcagdas It seems to me the autoconnect tries to connect one time when hitting the onclose event, but if it fails to connect then it doens't try to connect again.
Is there some recommended way to do this?
Also I noticed in the chat-signalr.service init method it calls abp.signalr.connect(); and then abp.signalr.startConnection. Could you explain a little what the need for both of them are, or how they work?
Yes, I would like the ability for a tenant to choose whether to use classic authentication or Azure AD (ADAL).
@klir If you create the issue, I'll give it a thumbs up. I also think the implementation should be multi-tenant aware.
Issue created here: <a class="postlink" href="https://github.com/aspnetzero/aspnet-zero-core/issues/1570">https://github.com/aspnetzero/aspnet-ze ... ssues/1570</a>
No, let me explain in more detail. I am running on a Windows machine. AspNetZero 5.3 AspNet Core/Angular merged project running on .Net Framework.
In our solution, we've been slowly adding tests and recently the tests started randomly failing. I couldn't find anything odd in our tests other than the amount of tests. I'm also suspicious it has something to do with db work since our tests hit the db pretty hard.
To replicate the issue I downloaded a clean 5.3 AspNet Core/Angular merged project, since that's what we're still using. I never have the issue running the tests out of box. But if I duplicate the out of box tests about 7 times (copy/paste/change test method name) so that there is a great volume of tests, the problem starts happening. I especially picked tests that hit the db, since I assumed that is the primary user of unmanaged memory.
BTW, even running tests in a clean project (without test duplication), you will see memory consumption slow increase.
@JustinP Were you able to implement a per-user licensing model? What about the recurring payment system?