Error on Social Registration #1483

4 Answer(s)

• 

  0

  kythor created 7 years ago

  After some debugging... this is what I found out:

  when trying to register through social login, twitter in this case, it takes me back to the Register View. The problem is that twitter does not return the email address. (any solution for that?)

  after filling in the register form with an email address, I continue by pressing Submit.

  it tries to validate the model through this:

  if (!UserName.Equals(EmailAddress) && emailRegex.IsMatch(UserName))
  

  but when initializing the Register View, the UserName is never set. So this line of code will always throw an error.

  When looking further, if I provide the "Default" tenant name in the code, it takes me directly to the "Register" method. and there again, the Username is being set using the EmailAddress

  model.UserName = model.EmailAddress
  

  but this is also Null...throwing in error as result.

  what to do? I think getting the email address from twitter would be the best solution, no?

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  First of all I got this solution from <a class="postlink" href="http://stackoverflow.com/questions/36330675/get-users-email-from-twitter-api-for-external-login-authentication-asp-net-mvc">http://stackoverflow.com/questions/3633 ... sp-net-mvc</a>.

  It seems like twitter does not return email address when user authanticates over twitter. You need to get email address from twitter after user allows your app for his/her account.

  To do that,

  1)Go to <a class="postlink" href="https://apps.twitter.com">https://apps.twitter.com</a> and under Permissions tab of your app, select "Request email addresses from users" checkbox on the bottom of page if you haven't alread done it. (It requires yo to provide Privacy Policy URL and Terms of Service URL but you can provide fake url's for test purposes).

  2. Set Provider property of TwitterAuthenticationOptions like this,

  Provider = new TwitterAuthenticationProvider
  {
      OnAuthenticated = (context) =>
      {
          context.Identity.AddClaim(new System.Security.Claims.Claim("urn:twitter:access_token", context.AccessToken));
          context.Identity.AddClaim(new System.Security.Claims.Claim("urn:twitter:access_secret", context.AccessTokenSecret));
          return Task.FromResult(0);
      }
  }
  

  3. in AccountController's ExternalLoginCallback action, you need to make a second request to twitter in order to get user's email.

  if (loginInfo.Login.LoginProvider.ToLower() == "twitter")
  {
      string access_token = loginInfo.ExternalIdentity.Claims.Where(x => x.Type == "urn:twitter:access_token").Select(x => x.Value).FirstOrDefault();
      string access_secret = loginInfo.ExternalIdentity.Claims.Where(x => x.Type == "urn:twitter:access_secret").Select(x => x.Value).FirstOrDefault();
      TwitterDto response = MyHelper.TwitterLogin(access_token, access_secret, ConfigurationManager.AppSettings["ExternalAuth.Twitter.ConsumerKey"], ConfigurationManager.AppSettings["ExternalAuth.Twitter.ConsumerSecret"]);
      loginInfo.Email = response.email;
  }
  

  4. Change Validate method of RegisterViewModel to

  var emailRegex = new Regex(@"^\w+([-+.']\w+)*@\w+([-.]\w+)*\.\w+([-.]\w+)*$");
  if (!UserName.IsNullOrEmpty() && !UserName.Equals(EmailAddress) && emailRegex.IsMatch(UserName))
  {
      yield return new ValidationResult("Username cannot be an email address unless it's same with your email address !");
  }
  

  You can find TwitterDto class and TwitterLogin method to get user's twitter email in related stackoverflow post. You can use a twitter library for getting user's email address. Please let us know if you have any problems while implementing this.

  Save Cancel
• 

  -1

  kythor created 7 years ago

  thanks for the help. I got it working, I can register automatically with my twitter account.

  Next problem is when I try to login with my Twitter account. This line in the code is called in method "ExternalLogin":

  var loginResult = await _userManager.LoginAsync(loginInfo.Login, tenancyName);
  

  but it always returns "UnknownExternalLogin", even though the account is registered and active...

  I'm wondering why loginInfo.Login is needed here, as it only holds "LoginProvider" and "ProviderKey". The actual UserInfo is in "loginInfo" itself.

  How to solve this?

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  Can you change this definition in accoun controller

  user.Logins = new List<UserLogin>
  {
      new UserLogin
      {
          LoginProvider = externalLoginInfo.Login.LoginProvider,
          ProviderKey = externalLoginInfo.Login.ProviderKey
      }
  };
  

  to

  user.Logins = new List<UserLogin>
  {
      new UserLogin
      {
          LoginProvider = externalLoginInfo.Login.LoginProvider,
          ProviderKey = externalLoginInfo.Login.ProviderKey,
          TenantId = tenant.Id
      }
  };
  

  we forgot to set tenantId when defining UserLogins. This will be fixed on the next release as well.

  Save Cancel