Exception is thrown before model validation is checked #1704

9 Answer(s)

• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  ABP framework handles validation for you by default on the server side. Also, it should be handled in the client side.

  You can view ABP's validation documents for more information <a class="postlink" href="http://aspnetboilerplate.com/Pages/Documents/MVC-Controllers#validation">http://aspnetboilerplate.com/Pages/Docu ... validation</a> <a class="postlink" href="http://aspnetboilerplate.com/Pages/Documents/Validating-Data-Transfer-Objects">http://aspnetboilerplate.com/Pages/Docu ... er-Objects</a>

  By the way, did you created your project from <a class="postlink" href="http://aspnetboilerplate.com/Templates">http://aspnetboilerplate.com/Templates</a> ? If so, try setting customErrors="On" in your web.config and see if you can see validation errors on client side ?

  Save Cancel
• 

  0

  djfuzzy created 7 years ago

  Yes, I have used the template. I am running ABP v0.10.3. I also read the documentation and have set CustomErrors to "On". I am still getting an Internal Server Error with the stack trace I posted above. I still am unable to figure out how to show the specific validation error on the calling form instead of the unhandled exception as shown above. I don't think my DTOs are being automatically validated as I have the call to the application service that is failing in a try/catch in my MVC controller. I would expect to get a friendly error saying Nickname is required instead of the internal server error. Here is my action method in my MVC controller:

  [HttpPost]
          [UnitOfWork]
          public virtual async Task<ActionResult> SignUp(SignUpViewModel model)
          {
              try
              {
                  CheckModelState();
                  
                  var input = new CreatePlayerWithNewUserInput()
                  {
                      User = new CreateUserInput
                      {
                          Nickname = model.Nickname,
                          EmailAddress = model.EmailAddress,
                          PasswordHashed = new PasswordHasher().HashPassword(model.Password),
                          IsActive = true
                      }
                  };
  
                  //Save user
                  await PlayerAppService.CreatePlayerWithNewUser(input);
                  await UnitOfWorkManager.Current.SaveChangesAsync();
  
                  //Directly login if possible
                  if (input.User.IsActive)
                  {
                      AbpUserManager<Tenant, Role, User>.AbpLoginResult loginResult;
                      loginResult = await GetLoginResultAsync(input.User.EmailAddress, model.Password);
  
                      if (loginResult.Result == AbpLoginResultType.Success)
                      {
                          await SignInAsync(loginResult.User, loginResult.Identity);
                          return Redirect(Url.Action("Index", "Home"));
                      }
  
                      Logger.Warn("New registered user could not be login. This should not be normally. login result: "
                          + loginResult.Result);
                  }
  
                  //If can not login, show a register result page
                  return View("SignUpResult", new SignUpResultViewModel
                  {
                      Nickname = input.User.Nickname,
                      EmailAddress = input.User.EmailAddress,
                      IsActive = input.User.IsActive
                  });
              }
              catch (UserFriendlyException ex)
              {
                  ViewBag.ErrorMessage = ex.Message;
                  ViewBag.ErrorDetails = ex.Details;
  
                  return SignUpView(model);
              }
              catch (Exception ex)
              {
                  ViewBag.ErrorMessage = ex.Message;
  
                  return SignUpView(model);
              }
          }
  

  Another thing that isn't working is when I have validation annotations in SignUpViewModel. I get a similar server error before the MVC controller action is even called. Something is not working.

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  ABP actually calls CheckModelState before calling the action method of controller by default. You can add [DisableValidation] attribute to your controller or action method, if you want to do validation manually.

  You can also disable validation for all MVC controllers like this in PreInitialize of your web module.

  Configuration.Modules.AbpMvc().IsValidationEnabledForControllers = false;
  

  Save Cancel
• 

  0

  djfuzzy created 7 years ago

  <cite>ismcagdas: </cite> Hi,

  ABP actually calls CheckModelState before calling the action method of controller by default. You can add [DisableValidation] attribute to your controller or action method, if you want to do validation manually.

  You can also disable validation for all MVC controllers like this in PreInitialize of your web module.

  Configuration.Modules.AbpMvc().IsValidationEnabledForControllers = false;
  

  Thank you, that's good to know.

  Save Cancel
• 

  0

  OutdoorEd created 7 years ago

  I tried to use {DisableValidation] both in individual Actions in the Controller and on the entire Controller but I still get Abp.Runtime.Validation.AbpValidationException: Method arguments are not valid

  If I add
  Configuration.Modules.AbpMvc().IsValidationEnabledForControllers = false; the MVC validation works however, it means that I have disabled validation for all of the Abp Controllers as well which I don't want to do (things like creating Users/Roles/Tenants etc.)

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi @OutdoorEd,

  Which version of ABP do you use ? As I remember there was an error related to this.

  Thanks.

  Save Cancel
• 

  0

  OutdoorEd created 7 years ago

  I am on v3.0.0.0

  Save Cancel
• 

  0

  OutdoorEd created 7 years ago

  What was the previous code issue?

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  I was asking about ABP's version. You can check it in your nuget references.

  Actually I couldn't find the issue but updating ABP can solve your problem if you can update it.

  Thanks.

  Save Cancel