I have followed the Elsa Integration documentation that came out in June. Everything appears to be good at first glance. I am using the latest AspNetZero version 12.2.
However, I have noticed that once Elsa is integrated into AspNetZero, the NSwag tool would no longer generate the Angular service-proxies.ts class correctly if we are creating a new page using the Power tools. The server side has all the newly generated code and app service class, but when Nswag re-generate the service-proxies.ts file, even the previously existing functions are updated. I have noticed that inside the typescript class of the generated proxy file, all the data type of the existing functions' input parameters are changed to the name of the server's input parameters' class name. Therefore, Angular codes go out of sync with the service proxy file.
In this example, the left handle side is the original file before running nswag, right hand side is the result after running NSwag. "GetAuditLogsInput" is the input parameter's class name on the server side.
Also, I have noticed that in the "Elsa.WorkflowDefinitions" table, there is a tenantId column. How do we have the value populated when a tenant is creating the workflow definition under his account? Is that something AspNetZero team can help with?
7 Answer(s)
-
0
Found the issue is at my end, I re-read the documentation of Elsa integration, and found out I am missing the "if (!enumType.IsEnum)" below.
var enumType = context?.ApiDescription?.ParameterDescriptions[i]?.ParameterDescriptor?.ParameterType; if (enumType == null) { continue; } if (!enumType.IsEnum) { continue; }If the support team can still help with TenantId issue on the WorkFlowDefinitions table, that would be great.
-
0
Hi @jamescliang
I assume you want to make WorkFlowDefinitions to be multi tenant, is that right ? I think it will require playing with Elsa's internals. We may give it a try when we have time.
-
0
Hello @ismcagdas,
I felt compelled to mention that our company shares a deep interest in ensuring a seamless integration of AspNetZero and Elsa core.
Most business systems require long-running workflows and business rule engines as a key feature. Therefore, having a robust and enriched workflow capability holds immense importance for various organisations, including ours.
We have taken a comprehensive look at your roadmap for core and jquery. In our perspective, it holds greater importance than aspects such as coupon features, error messages via email (considering the wide availability of excellent third-party alternatives), or menu item ordering, a problem we've already found a solution to. Our concern lies in the absence of any explicit commitment towards addressing issues concerning Elsa integration on a permanent basis. In my humble opinion, this could be a significant oversight.
We, therefore, respectfully request you to prioritize this issue, as we believe the matters related to Elsa are not being given the necessary urgency and attention they truly deserve.
-
0
Hi @mightyit,
Thank you for bringing up your concerns regarding Elsa's integration. We value your feedback and understand the importance of having a robust workflow capability for your organization and others.
We apologize for the oversight in not explicitly addressing the Elsa integration in our current roadmap. Rest assured, we are committed to continuously improving our product to meet your needs. After considering your feedback, we will prioritize discussions around incorporating Elsa into our upcoming milestones.
Thank you once again for your valuable input.
-
0
Hi @mightyit,
Thank you for bringing up your concerns regarding Elsa's integration. We value your feedback and understand the importance of having a robust workflow capability for your organization and others.
We apologize for the oversight in not explicitly addressing the Elsa integration in our current roadmap. Rest assured, we are committed to continuously improving our product to meet your needs. After considering your feedback, we will prioritize discussions around incorporating Elsa into our upcoming milestones.
Thank you once again for your valuable input.
Hi there, Support Team!
We were just hoping to get some feedback since you stated about a month ago that you would prioritise discussions around Elsa's integration into your upcoming milestones. Will this be addressed in a future milestone, and when do you expect this to occur?
Sorry for the persistence on this issue, but we also need to make decisions about the future direction of our systems.
Kind regards
-
1
Hi,
We have written a blog post about integrating Elsa with ASP.NET Zero's Angular version, you can check it out here https://aspnetzero.com/blog/integrating-elsa-with-aspnet-zero-angular
-
0
Hi @ismcagdas
This is great news, thank you!
We are running on ASP.NET CORE MVC & jQuery and will try to adapt from the article for ASP.NET Zero's Angular version. Anything in particular you feel we should consider in this case?
Just a note that the link in the article to the ElsaDemo github repo gives a 404 error, you might want to just review that.
