Error on deleting an Entity after update to 0.9.3 #2536

5 Answer(s)

• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  If it is possible for you, can you upgrade to v1.0 ? I couldn't remember an issue related to this problem, but updating to v1.0 might fix this. If it does not, we can try to debug it by your code.

  Thanks.

  Save Cancel
• 

  0

  eggersa created 7 years ago

  After a while of debugging I found the issue that was in fact already introduced with 0.9.0.0 as far as I'm concerned.

  In 0.8.4 the Delete method in the EfRepositoryBaseOfTEntityAndTPrimaryKey is implemented like this:

  public override void Delete(TEntity entity)
          {
              AttachIfNot(entity);
  
              if (entity is ISoftDelete)
              {
                  (entity as ISoftDelete).IsDeleted = true;
              }
              else
              {
                  Table.Remove(entity);
              }
          }
  

  However, in the later version the method was for some reason changed to:

  public override void Delete(TEntity entity)
          {
              AttachIfNot(entity);
              Table.Remove(entity);
          }
  

  The Remove method of Table (DbSet) internally clears all foreign keys including my Owner property (foreign key) which is marked as required. However, the SoftDelete logic later on modifies the entity and prevents its actual deletion which of course causes a validation and the results in a validation exception.

  Is there any chance to workaround this issue?

  Please do not take any offense on the following (I do a lot of erros myself and I love your framework anyway), but so far with every update was a new bug introduced that caused painful conversations with our client. Therefore I cannot afford another update.

  0.8.4 -> 0.9.0 Bug and the Delete bug 0.9.0 -> 0.9.1.1 Bug

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  Hi,

  No problem at all :). We are trying to make small changes between each version but sometimes it is not possible as you know in software and before 1.0 of ABP there are some changes like you mentioned. I suggest to you to follow the latest ABP version in your project if you can. I know that it might be a painfull thing to do but, you might face much more problem if you don't in the future.

  Currently, you can override the Delete method in your RepositoryBase and change it to older version if you like, what about that ?

  Save Cancel
• 

  0

  eggersa created 7 years ago

  Thank you. That seems to work for me ;). We will probably update to the latest version with the next big feature request. But that really depends on our client. Lets hope is willing to pay.

  Save Cancel
• 

  0

  ismcagdas created 7 years ago

  Support Team

  You are right, there is a customer reality at the end :).

  Save Cancel