Hi,
I'm trying to contribute the code for the mexican spanish translation. I first tried to create a new branch and then send a pull request from my branch to the Dev branch (no success). Later tried to make changes directry on the Dev branch and send the pull request from Dev to Master branch.
I keep getting error messages.
I'm new on github and I'm not sure how I should contribute.
Could you please advise.
Thanks.
6 Answer(s)
-
0
Hi,
You don't have direct commit rights but pull request should work. Can you share the error you are getting when you try to send a pull request ?
Thanks.
-
0
Hi,
Here are the screenshots. First it send a "Sync Failed" error and later a "Request Failed" error.
Felix.
-
0
Finally I was able to do it. I had to first fork the project.
By the way, you also need to add these files: angular\node_modules\bootstrap-select\dist\js\i18n\defaults-es_MX.js angular\node_modules\bootstrap-select\dist\js\i18n\defaults-es_MX.min.js angular\node_modules\jtable\lib\localization\jquery.jtable.es-MX.js angular\node_modules\timeago\locales\jquery.timeago.es-MX-short.js
I wasn't able to do it because those paths are not part of the project.
Felix.
-
0
Hi,
Thank you very much for your contribution. Those files should be installed when you install node packages.
Do you want to create MX localization for those libraries as well ? If so, you need to send pull request to their repositories I think.
-
0
Hi,
I can send the pull request but I don't think I have access to the repo of the node packages, or do I? Where can i find that repo?
Thanks, Felix.
-
0
Hi,
No, you need to send pull request to bootstrap-select, jtable and timeago github repositories. Then they should update their npm packages.
Thanks.
