PhoneBookDemo "AddPhone and DeletePhone Method" fails Tests. #4934

12 Answer(s)

• 

  0

  alper created 6 years ago

  Support Team

  Please double check all the steps.

  Save Cancel
• 

  0

  TimMackey created 6 years ago

  First of all, please note that I corrected the title.

  To your point to double check all the steps...

  The instructions are a bit cryptic at this point, i.e. "(Note: We injected IRepository<Phone, long> in the constructor and set to _personRepository field, as similar to _personRepository)"

  I included in the previous post the code that I wrote so that someone could verify if it follows the above instruction. Please refer to the attached .zip file for the changed code. Thank you. AddPhone-and-DeletePhone-Method-Error.zip

  Save Cancel
• 

  0

  aaron created 6 years ago

  Support Team

  First of all, please note that I corrected the title.

  First of all, please don't change the original post after someone has answered it. Post a new topic instead.

  The instructions are a bit cryptic at this point, i.e. "(Note: We injected IRepository<Phone, long> in the constructor and set to _personRepository field, as similar to _personRepository)"

  It should be: "(Note: We injected IRepository<Phone, long> in the constructor and set to _phoneRepository field, as similar to _personRepository)"

  I included in the previous post the code that I wrote so that someone could verify if it follows the above instruction. Please refer to the attached .zip file for the changed code.

  There's nothing about AddPhone or DeletePhone "included in the previous post". Referring to the attached .zip file, this is the contents of your PersonAppService.cs:

  namespace PhoneBookDemo.Persons.Dto
  {
      public class GetPeopleInput
      {
          // ...
      }
  
      public class PersonListDto : FullAuditedEntityDto
      {
          // ...
      }
  
      public class PhoneInPersonListDto : CreationAuditedEntityDto<long>
      {
          // ...
      }
  
      public class AddPhoneInput
      {
          // ...
      }
  }
  

  Please double check.

  Save Cancel
• 

  0

  TimMackey created 6 years ago

  There's nothing about AddPhone or DeletePhone "included in the previous post".

  Actually if you give it a read again there is code starting at the 3rd line, and it is how I implemented the constructor of PersonAppService, My apologies for not using the code tags to highlight it. But that is beside the main points, which I will get to in a moment. It does appear that I have implemented it correctly. Thank you for correcting the instructions.

  Also, it was my intent to reference a section in the developer instructions page... [https://aspnetzero.com/Documents/Developing-Step-By-Step-Angular#creating-a-new-person]) ...when I said "Acme.PhoneBookDemo-Angular, "AddPhone and DeletePhone Methods" section..." - I was not referring to the AddPhone or DeletePhone methods.

  In the same page at section "Creating Person Application Service" the instructions say... "Application service interface and DTOs are located in .Application.Shared project." This makes sense given most other DTOs are located in the project. However, going to the github repository ... [https://github.com/aspnetzero/aspnet-zero-samples/tree/master/PhoneBook-Angular]) ... to double check my implementation I discover that the application service interface and DTO folder are in the .Application project.

  My questions are:

  1. Could this be why my code does not pass Tests?
  2. Which is the correct project to implement the interface; .Application or .Application.Shared?
  3. Why does the github repository has version 5.0.0 code and the code generator emit version 5.3.0 code? There are 102 text files with differences between versions. This makes code checking difficult.
  4. Why are Dto folders for Configuration, Install, and MultiTenancy in the .Application project? This breaks the pattern of most Dto folders being located in the .Application.Shared project.

  I have double checked all my code, and as best as I can follow the instructions, I believe I have implemented the code correctly. I remain baffled why it will not pass all Tests.

  I've attached the related projects in a zip file if you care to investigate into which folders are the files I implemented the code in, and if the code is correct. Thank you for your assistance. PhoneBookDemo.src.zip

  Save Cancel
• 

  0

  aaron created 6 years ago

  Support Team

  Try this:

  public ListResultDto<PersonListDto> GetPeople(GetPeopleInput input)
  {
      // ...
  
      // return new ListResultDto<PersonListDto>(persons.MapTo<List<PersonListDto>>());
      return new ListResultDto<PersonListDto>(ObjectMapper.Map<List<PersonListDto>>(persons));
  }
  

  Save Cancel
• 

  0

  TimMackey created 6 years ago

  Your posted solution works. Thank you for updating the instructions document.

  Until the aspnet-zero-samples/PhoneBook-Angular project on github is updated and tested, those files are basically useless as a reference when problems arise.

  Save Cancel
• 

  0

  alper created 6 years ago

  Support Team

  Thanks @aaron and @TimMackey. Fixed the code on GitHub and updated the documentation.

  Save Cancel
• 

  0

  duffyvector created 6 years ago

  Hello, I found this post while researching where to add the

  using Abp.Application.Services;
  using Abp.Application.Services.Dto;
  
  namespace Acme.PhoneBookDemo.PhoneBook
  {
      public interface IPersonAppService : IApplicationService
      {
          ListResultDto<PersonListDto> GetPeople(GetPeopleInput input);
      }
  }
  

  It had a reference to the samples on GIThub: aspnet-zero-samples/PhoneBook-Angular project on github

  @aaron is there a completed solution to track where I may go wrong on this demo?

  Save Cancel
• 

  0

  aaron created 6 years ago

  Support Team

  https://github.com/aspnetzero/aspnet-zero-samples/tree/master/PhoneBook-Angular

  Save Cancel
• 

  0

  duffyvector created 6 years ago

  @aaron - yes I tried that but I get a 404 not found

  <a class="postlink" href="https://github.com/aspnetzero/aspnet-zero-samples/tree/master/PhoneBook-Angular">https://github.com/aspnetzero/aspnet-ze ... ok-Angular</a>

  Save Cancel
• 

  0

  duffyvector created 6 years ago

  Sory for the confusion I needed to add myself to the private github area via the licensing screen on <a class="postlink" href="https://aspnetzero.com/LicenseManagement">https://aspnetzero.com/LicenseManagement</a>. Got it now!! Thanks

  Save Cancel
• 

  0

  alirizaadiyahsi created 6 years ago

  Thanks for feedback.

  Save Cancel