Open DataReader exception calling GetCurrentUser #7135

dev_frontrush created 5 years ago

Hello,

A developer on our team is getting an error about having an open data reader but it only happens in their development environment. We have a base class that inherits the AppNameAppServiceBase class and makes use of the GetCurrentUser() and GetCurrentTenant() base class methods. It seems like they are running multiple debugging instances or something similar and/or their local database configuration may be specific where either pooling isn't configured or??? The odd part is the debugger doesn't catch the exception it just silently fails with a 500 error from the inheriting ServiceNameAppService. Below is an example/similar class:

/// &lt;summary&gt;
/// SomeApplicationServiceBase
/// &lt;/summary&gt;
/// &lt;remarks&gt;
/// Base class for services that require a tenant and an active other entity.
/// &lt;/remarks&gt;
public abstract class RequiredEntityApplicationServiceBase : AppNameAppServiceBase
{
    // the other entity is a junction table between the AbpUsers and the other application entity
    protected readonly IRepository&lt;UserRequiredEntity&gt; _otherEntityRepository;

    /// &lt;summary&gt;
    /// Constructor
    /// &lt;/summary&gt;
    public RequiredEntityApplicationServiceBase(IRepository&lt;UserRequiredEntity&gt; userRequiredEntityRepository)
    {
        this._userRequiredEntityRepository = userRequiredEntityRepository;
    }

    protected virtual RequiredEntity GetRequiredEntity()
    {
        RequiredEntity requiredEntity = null;
        
        // Fails here silently with DataReader currently open exception
        var user = this.GetCurrentUser();

        ...
        
        return requiredEntity;
    }

    public int TenantId
    {
        get
        {
            return this.GetCurrentTenant().Id;
        }
    }

    
    public int RequiredEntityId
    {
        get
        {
            return this.GetRequiredEntity().Id;
        }
    }
}

Any ideas? Should the UserManager and AbpSession be injected into the base?

1 Answer(s)