Hi,
We're performing load tests on our application using JMeter, and we've noticed a lot of DB queries to get the current tenant details. I'm assuming it's for correctly configuring the Unit Of Work.for each API service call etc.
We're investigating caching the Tenant details, as it's unlikey the Tenant details are likely to change that often, in order to reduce the numbers of queries to the DB.
My questions are, does the ABP framework already cache tenant details? If not, does the framework use TenantManager or IRepository<Tenant> to perform these queries? What's the simplest way to cache Tenant details?
Thanks,
Hi,
Yes it does, thank you.
Hi,
Apologies, I think I've found the issue. The method I'm calling to enqueue the job is an async method, and I was calling it in n non-async method. I thought Visual Studio would produce a compiler warning for this but it doesn't.
Calling BackgroundJobManager.EnqueueAsync in a non-async method can produce unexpected results, because BackgroundJobManager is a singleton, which means the IBackgroundJobStore can end up participating in multiple, unrelated UnitOfWorks. This can result in multiple in UnitOfWorks trying to insert the same job, depending on thread timing.
Apologies, again.
Hi,
Yes, we're hosting the application in a single docker container. I also get this error when running the application locally on my development machine.
We're also using the database per tenant architecure, but I don't think this is the issue because as far as I can tell the background jobs are always created in the host DB.
Thanks
Hi,
ABP Version: 5.6 AspNetZero Angular 8.6 .NET Core
I'm using the default BackgroundJobManager, provided by ABP, to enqueue and process background jobs.
I'm enqueuing a background job to send email notifications. However, every second or third attempt to enqueue the job throws the following error:
error occurred while updating the entries. See the inner exception for details. at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection connection)
at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.Execute(IEnumerable`1 commandBatches, IRelationalConnection connection)
at Microsoft.EntityFrameworkCore.Storage.RelationalDatabase.SaveChanges(IList`1 entries)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(IList`1 entriesToSave)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(DbContext _, Boolean acceptAllChangesOnSuccess)
at Npgsql.EntityFrameworkCore.PostgreSQL.Storage.Internal.NpgsqlExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded)
at Microsoft.EntityFrameworkCore.DbContext.SaveChanges(Boolean acceptAllChangesOnSuccess)
at Abp.EntityFrameworkCore.AbpDbContext.SaveChanges()
at Abp.Zero.EntityFrameworkCore.AbpZeroCommonDbContext`3.SaveChanges()
at Abp.EntityFrameworkCore.Uow.EfCoreUnitOfWork.SaveChangesInDbContext(DbContext dbContext)
at Abp.EntityFrameworkCore.Uow.EfCoreUnitOfWork.SaveChanges()
at Abp.EntityFrameworkCore.Uow.EfCoreUnitOfWork.CompleteUow()
at Abp.Domain.Uow.UnitOfWorkBase.Complete()
at RMS.Workflow.WorkflowAppService.SubmitAsync(ItemActionRequestDto request) in C:\Development\IDS\RMS\Main\src\RMS.Workflow\Workflow\WorkflowAppService.cs:line 278
at Abp.Authorization.AuthorizationInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Domain.Uow.UnitOfWorkInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Domain.Uow.UnitOfWorkInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Auditing.AuditingInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Auditing.AuditingInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Runtime.Validation.Interception.ValidationInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at RMS.Items.ItemAppService.SubmitAsync(ItemActionRequestDto request) in C:\Development\IDS\RMS\Main\src\RMS.Application\Items\ItemAppService.cs:line 188
at Abp.Authorization.AuthorizationInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Domain.Uow.UnitOfWorkInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Domain.Uow.UnitOfWorkInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Auditing.AuditingInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at Abp.Runtime.Validation.Interception.ValidationInterceptor.InternalInterceptAsynchronous(IInvocation invocation)
at lambda_method(Closure , Object )
at Microsoft.Extensions.Internal.ObjectMethodExecutorAwaitable.Awaiter.GetResult()
at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextExceptionFilterAsync>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
23505: duplicate key value violates unique constraint "PK_AbpBackgroundJobs" at Npgsql.NpgsqlConnector.<>c__DisplayClass160_0.<<DoReadMessage>g__ReadMessageLong|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at Npgsql.NpgsqlConnector.<>c__DisplayClass160_0.<<DoReadMessage>g__ReadMessageLong|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at Npgsql.NpgsqlDataReader.NextResult(Boolean async, Boolean isConsuming)
at Npgsql.NpgsqlDataReader.NextResult()
at Npgsql.NpgsqlCommand.ExecuteReaderAsync(CommandBehavior behavior, Boolean async, CancellationToken cancellationToken)
at Npgsql.NpgsqlCommand.ExecuteReader(CommandBehavior behavior)
at Microsoft.EntityFrameworkCore.Storage.RelationalCommand.ExecuteReader(RelationalCommandParameterObject parameterObject)
at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection ]connection) Severity: ERROR;InvariantSeverity: ERROR;SqlState: 23505;MessageText: duplicate key value violates unique constraint "PK_AbpBackgroundJobs";Detail: Key ("Id")=(6) already exists.;SchemaName: public;TableName: AbpBackgroundJobs;ConstraintName: PK_AbpBackgroundJobs;File: d:\pginstaller_12.auto\postgres.windows-x64\src\backend\access\nbtree\nbtinsert.c;Line: 570;Routine: _bt_check_unique"
As you can see, it looks the BackgroundJobManager is trying to re-insert a job entry with the same ID.
Below is how I'm enqueueing the job:
/// <summary>
/// Sends the collection of templated notifications
/// </summary>
/// <param name="notifications"></param>
/// <returns></returns>
public async Task SendAsync(IEnumerable<TemplatedNotification> notifications)
{
foreach(var notification in notifications)
{
// Enqueue the job
await _backgroundJobManager.EnqueueAsync<SendTemplatedNotificationJob, TemplatedNotification>(notification);
}
}
Below is the background job definition:
public class SendTemplatedNotificationJob : BackgroundJob<TemplatedNotification>, ITransientDependency
{
#region Constructors
public SendTemplatedNotificationJob(
IEmailSender emailSender,
IRepository<NotificationTemplate> notificationTemplateRepository,
UserManager userManager
)
{
Guard.ArgumentNotNull(emailSender, nameof(emailSender));
Guard.ArgumentNotNull(notificationTemplateRepository, nameof(notificationTemplateRepository));
Guard.ArgumentNotNull(userManager, nameof(userManager));
_emailSender = emailSender;
_notificationTemplateRepository = notificationTemplateRepository;
_userManager = userManager;
AbpSession = NullAbpSession.Instance;
}
#endregion
#region Properties
public IAbpSession AbpSession { get; set; }
#endregion
#region Fields
private readonly IEmailSender _emailSender;
private readonly IRepository<NotificationTemplate> _notificationTemplateRepository;
private readonly UserManager _userManager;
#endregion
#region Methods
/// <summary>
/// Sends the specified notification
/// </summary>
/// <param name="notification"></param>
[UnitOfWork]
public override void Execute(TemplatedNotification notification)
{
// TODO: Cater for other notification channels, besides email
if(notification != null)
{
// Switch to correct tenant
using (CurrentUnitOfWork.SetTenantId(notification.TenantId))
{
// Set the session
using (AbpSession.Use(notification.TenantId, null))
{
// Get the template
var template = _notificationTemplateRepository.FirstOrDefault(t => t.Code == notification.TemplateCode);
if (template == null)
{
// Try to get the non-tenant template
using (CurrentUnitOfWork.DisableFilter(AbpDataFilters.MayHaveTenant))
{
template = _notificationTemplateRepository.FirstOrDefault(t => t.Code == notification.TemplateCode);
}
}
if (template != null)
{
// First build the list of recipients
HashSet<string> recipients = new HashSet<string>();
// Get recipients by user identifier
foreach (var userIndentifier in notification.RecipientIdentifiers)
{
var user = _userManager.GetUserOrNull(userIndentifier);
if (!string.IsNullOrWhiteSpace(user?.EmailAddress))
{
recipients.Add(user.EmailAddress);
}
}
// TODO: Get recipients by role
if (recipients.Any())
{
// Build template body
StringBuilder body = new StringBuilder(template.Body);
foreach (var key in notification.TemplateKeyValues.Keys)
{
body.Replace($"<%{key}%>", notification.TemplateKeyValues[key] ?? string.Empty);
}
// Construct mail message
MailMessage mailMessage = new MailMessage();
recipients.ForEach(r => mailMessage.To.Add(r));
mailMessage.Subject = template.Subject;
mailMessage.Body = body.ToString();
mailMessage.IsBodyHtml = true;
// Send the email
_emailSender.Send(mailMessage);
}
}
}
}
}
}
#endregion
}
Thanks
Thank you!
ASP.NET CORE MVC & jQuery, .NET CORE 3.1, v8.4
I have forgotten my host password - trying to reset using 'Forgot Password' link is not working (unknown password). How can I do this?
Hi,
I tested my assumption about TransactionScope.Suppress and I was correct. The inner scope doesn't wait for the outer scope to complete before the changes show in the database. Please see the code below.
using (var outerScope = new TransactionScope(TransactionScopeOption.Suppress))
{
var outerConnection = new SqlConnection("Server=localhost;Database=Test;Trusted_Connection=true;Integrated Security=True;");
outerConnection.Open();
var command = outerConnection.CreateCommand();
command.CommandText = "SELECT * FROM dbo.ResearchProjects";
command.ExecuteNonQuery();
using (var innerScope = new TransactionScope(TransactionScopeOption.Required))
{
var innerCommand = outerConnection.CreateCommand();
command.CommandText = $"INSERT INTO dbo.ResearchProjects(ID) VALUES('{Guid.NewGuid()}');";
command.ExecuteNonQuery();
innerScope.Complete();
}
outerScope.Complete();
}
I still think UnitOfWork in ABP should work the same way.
I appreciate that it currently does not work this way, so my question is how can I disable UnitOfWork interceptor for a specific ApplicationService. I can't use [UnitOfWork(IsDisabled=true)] because this ApplicationService gets called by other ApplicationServices.
Thanks,
Hi,
I tried CurrentUnitOfWork.SaveChangesAsync() but it doens't solve the problem. It saves the changes in the context of the transaction (IE. genrate entity IDs etc) but those changes don't show in the DB until the outer unit of work has completed.
This is bad because it means the outer unit of work is keeping alive the transaction created in the inner unit of work. That goes against how TransactionScope.Suppress is supposed to work. The outer unit or work (created with TransactionScope.Suppress) is behaving like it was created with TransactionScope.Required.
For example, consider the code below (in a non-ABP scenario). As far as I know, changes made in innerScope will complete and reflect as soon as the innerScope has completed. It won't wait for outerScope to complete first.
using(var outerScope = new TransactionScope(TransactionScopeOption.Suppress)){
using(var innerScope = new TransactionScope(TransactionScopeOption.Required)){
// Make changes
...
innerScope.Complete();
}
outerScope.Complete();
}