Many Thanks for you help. Our workaround is very similar. We had multiple issues with the DefaultRedisCacheSerializer:
This is our cache serializer :
using Abp.Dependency; using Abp.Runtime.Caching.Redis; using Abp.Runtime.Caching; using StackExchange.Redis; using System; using System.Text.Encodings.Web; using System.Text.Json; using Abp.Json; using System.Text.Json.Serialization; using Abp.Json.SystemTextJson;
namespace RmoniWeb.Helpers { public class RmoniWebRedisCacheSerializer : IRedisCacheSerializer, ITransientDependency { /// <summary> /// Creates an instance of the object from its serialized string representation. /// </summary> /// <param name="objbyte">String representation of the object from the Redis server.</param> /// <returns>Returns a newly constructed object.</returns> /// <seealso cref="IRedisCacheSerializer{TSource, TDestination}.Serialize" /> public virtual object Deserialize(RedisValue objbyte) private readonly JsonSerializerOptions _simpleJsonSerializerOptions = new() { Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping, ReferenceHandler = ReferenceHandler.Preserve };
private readonly JsonSerializerOptions _jsonSerializerOptionsWithConverters = new()
{
ReadCommentHandling = JsonCommentHandling.Skip,
AllowTrailingCommas = true,
Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
TypeInfoResolver = new AbpDateTimeJsonTypeInfoResolver(),
ReferenceHandler = ReferenceHandler.Preserve,
Converters =
{
new AbpStringToEnumFactory(),
new AbpStringToBooleanConverter(),
new AbpStringToGuidConverter(),
new AbpNullableStringToGuidConverter(),
new AbpNullableFromEmptyStringConverterFactory(),
new ObjectToInferredTypesConverter(),
new AbpJsonConverterForType(),
new ExternalLoginProviderInfoConverter(),
}
};
/// <summary>
/// Creates an instance of the object from its serialized string representation.
/// </summary>
/// <param name="objbyte">String representation of the object from the Redis server.</param>
/// <returns>Returns a newly constructed object.</returns>
/// <seealso cref="IRedisCacheSerializer{TSource, TDestination}.Serialize" />
public virtual object Deserialize(RedisValue objbyte)
{
if ((string)objbyte is null)
return null;
var convertedValue = JsonSerializer.Deserialize<AbpCacheData>(objbyte, _jsonSerializerOptionsWithConverters);
var type = Type.GetType(convertedValue.Type, true, true);
return convertedValue.Payload.FromJsonString(type, _jsonSerializerOptionsWithConverters);
}
private readonly JsonSerializerOptions _simpleJsonSerializerOptions = new()
{
Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
ReferenceHandler = ReferenceHandler.Preserve
};
private readonly JsonSerializerOptions _jsonSerializerOptionsWithConverters = new()
{
ReadCommentHandling = JsonCommentHandling.Skip,
AllowTrailingCommas = true,
Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,
TypeInfoResolver = new AbpDateTimeJsonTypeInfoResolver(),
ReferenceHandler = ReferenceHandler.Preserve,
Converters =
{
new AbpStringToEnumFactory(),
new AbpStringToBooleanConverter(),
new AbpStringToGuidConverter(),
new AbpNullableStringToGuidConverter(),
new AbpNullableFromEmptyStringConverterFactory(),
new ObjectToInferredTypesConverter(),
new AbpJsonConverterForType(),
new ExternalLoginProviderInfoConverter(),
}
};
/// <summary>
/// Produce a string representation of the supplied object.
/// </summary>
/// <param name="value">Instance to serialize.</param>
/// <param name="type">Type of the object.</param>
/// <returns>Returns a string representing the object instance that can be placed into the Redis cache.</returns>
/// <seealso cref="IRedisCacheSerializer{TSource, TDestination}.Deserialize" />
public virtual RedisValue Serialize(object value, Type type)
{
var typeString = TypeHelper.SerializeType(value.GetType()).ToString();
var convertedValue = JsonSerializer.Serialize(value, _jsonSerializerOptionsWithConverters);
var json = new AbpCacheData(typeString, convertedValue);
return JsonSerializer.Serialize(json, _jsonSerializerOptionsWithConverters);
}
}
}
This is the converter for ExterLoginProviderInfo: using Abp.AspNetZeroCore.Web.Authentication.External; using System; using System.Collections.Generic; using System.Linq; using System.Text; using System.Text.Json; using System.Text.Json.Serialization; using System.Threading.Tasks;
namespace RmoniWeb.Helpers { public class ExternalLoginProviderInfoConverter : JsonConverter<ExternalLoginProviderInfo> { private Dictionary<string, string> ReadDictionary(ref Utf8JsonReader reader) { Dictionary<string, string> dictionary = new Dictionary<string, string>(); while (reader.Read()) { if (reader.TokenType == JsonTokenType.EndObject) { break; } if (reader.TokenType != JsonTokenType.StartObject) { throw new JsonException("Expected StartObject token."); }
while (reader.Read())
{
if (reader.TokenType == JsonTokenType.EndObject)
{
// End of the current JsonClaimMap object, break
break;
}
// Read the key (property name)
if (reader.TokenType == JsonTokenType.PropertyName)
{
string key = reader.GetString();
// Read the value
reader.Read();
if (reader.TokenType != JsonTokenType.Null && reader.TokenType != JsonTokenType.String)
{
throw new JsonException("Expected string value.");
}
string value = reader.GetString();
// Add the key-value pair to the dictionary
dictionary[key] = value;
}
}
}
return dictionary;
}
private List<JsonClaimMap> ReadJsonClaimMapList(ref Utf8JsonReader reader)
{
List<JsonClaimMap> claimMapList = new List<JsonClaimMap>();
// Ensure we are at the start of an array
//if (reader.TokenType != JsonTokenType.StartArray)
//{
// throw new JsonException("Expected StartArray token.");
//}
// Read the array
while (reader.Read())
{
// Break if we reach the end of the array
if (reader.TokenType == JsonTokenType.EndArray)
{
break;
}
// Ensure we're starting an object
if (reader.TokenType != JsonTokenType.StartArray)
{
throw new JsonException("Expected StartArray token.");
}
// Create a new JsonClaimMap instance
JsonClaimMap claimMap = new JsonClaimMap();
// Read properties within the object
while (reader.Read())
{
if (reader.TokenType == JsonTokenType.EndObject)
{
// End of the current JsonClaimMap object, break
break;
}
// Get the property name
if (reader.TokenType == JsonTokenType.PropertyName)
{
string propertyName = reader.GetString();
// Read the next token (which should be the value)
if (!reader.Read())
{
throw new JsonException("Expected a value after property name.");
}
// Assign the property based on the property name
if (propertyName == "Claim")
{
claimMap.Claim = reader.GetString();
}
else if (propertyName == "Key")
{
claimMap.Key = reader.GetString();
}
}
}
// Add the parsed JsonClaimMap to the list
claimMapList.Add(claimMap);
}
return claimMapList;
}
public override ExternalLoginProviderInfo Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
// Create a temporary object to hold the JSON data
Dictionary<string, object> tempObject = JsonSerializer.Deserialize<Dictionary<string, object>>(ref reader, options);
// Extract the properties manually
string name = tempObject["Name"]?.ToString();
string clientId = tempObject["ClientId"]?.ToString();
string clientSecret = tempObject["ClientSecret"]?.ToString();
Type providerApiType = Type.GetType(tempObject["ProviderApiType"].ToString());
//Dictionary<string, string> additionalParams = JsonSerializer.Deserialize<Dictionary<string, string>>(tempObject["AdditionalParams"].ToString());
byte[] paramBytes = Encoding.UTF8.GetBytes(tempObject["AdditionalParams"].ToString());
Type providerApiType = Type.GetType(tempObject["ProviderApiType"]?.ToString());
byte[] paramBytes = Encoding.UTF8.GetBytes(tempObject["AdditionalParams"]?.ToString());
ReadOnlySpan<byte> paramSpan = new ReadOnlySpan<byte>(paramBytes);
var paramReader = new Utf8JsonReader(paramSpan);
var additionalParams = ReadDictionary(ref paramReader);
byte[] claimBytes = Encoding.UTF8.GetBytes(tempObject["ClaimMappings"].ToString());
byte[] claimBytes = Encoding.UTF8.GetBytes(tempObject["ClaimMappings"]?.ToString());
ReadOnlySpan<byte> claimSpan = new ReadOnlySpan<byte>(claimBytes);
var claimReader = new Utf8JsonReader(claimSpan);
var claimMappings = ReadJsonClaimMapList(ref claimReader);
// Create the ExternalLoginProviderInfo instance using the constructor
return new ExternalLoginProviderInfo(name, clientId, clientSecret, providerApiType, additionalParams, claimMappings);
}
public override void Write(Utf8JsonWriter writer, ExternalLoginProviderInfo value, JsonSerializerOptions options)
{
// Handle serialization if needed
writer.WriteStartObject();
writer.WriteString("Name", value.Name);
writer.WriteString("ClientId", value.ClientId);
writer.WriteString("ClientSecret", value.ClientSecret);
var assemblyQualifiedName = TypeHelper.SerializeType(value.ProviderApiType).ToString();
writer.WriteString("ProviderApiType", assemblyQualifiedName);
writer.WritePropertyName("AdditionalParams");
writer.WriteStartObject();
foreach (var kvp in value.AdditionalParams)
{
// Write each key-value pair as a JSON property
writer.WriteString(kvp.Key, kvp.Value);
}
writer.WriteEndObject();
writer.WritePropertyName("ClaimMappings");
writer.WriteStartArray();
foreach (var claim in value.ClaimMappings)
{
writer.WriteStartObject();
writer.WriteString("Claim", claim.Claim);
writer.WriteString("Key", claim.Key);
writer.WriteEndObject();
}
writer.WriteEndArray();
writer.WriteEndObject();
}
}
private static Dictionary<string, string> ReadDictionary(ref Utf8JsonReader reader)
{
var dictionary = new Dictionary<string, string>();
while (reader.Read())
{
if (reader.TokenType == JsonTokenType.EndObject)
{
break;
}
if (reader.TokenType != JsonTokenType.StartObject)
{
throw new JsonException("Expected StartObject token.");
}
while (reader.Read())
{
if (reader.TokenType == JsonTokenType.EndObject)
{
// End of the current JsonClaimMap object, break
break;
}
// Read the key (property name)
if (reader.TokenType == JsonTokenType.PropertyName)
{
var key = reader.GetString();
// Read the value
reader.Read();
if (reader.TokenType != JsonTokenType.Null && reader.TokenType != JsonTokenType.String)
{
throw new JsonException("Expected string value.");
}
var value = reader.GetString();
// Add the key-value pair to the dictionary
if (key != null)
dictionary[key] = value;
}
}
}
return dictionary;
}
private static List<JsonClaimMap> ReadJsonClaimMapList(ref Utf8JsonReader reader)
{
List<JsonClaimMap> claimMapList = new List<JsonClaimMap>();
// Read the array
while (reader.Read())
{
// Break if we reach the end of the array
if (reader.TokenType == JsonTokenType.EndArray)
{
break;
}
// Ensure we're starting an object
if (reader.TokenType != JsonTokenType.StartArray)
{
throw new JsonException("Expected StartArray token.");
}
// Create a new JsonClaimMap instance
JsonClaimMap claimMap = new JsonClaimMap();
// Read properties within the object
while (reader.Read())
{
if (reader.TokenType == JsonTokenType.EndObject)
{
// End of the current JsonClaimMap object, break
break;
}
// Get the property name
if (reader.TokenType == JsonTokenType.PropertyName)
{
string propertyName = reader.GetString();
// Read the next token (which should be the value)
if (!reader.Read())
{
throw new JsonException("Expected a value after property name.");
}
// Assign the property based on the property name
if (propertyName == "Claim")
{
claimMap.Claim = reader.GetString();
}
else if (propertyName == "Key")
{
claimMap.Key = reader.GetString();
}
}
}
// Add the parsed JsonClaimMap to the list
claimMapList.Add(claimMap);
}
return claimMapList;
}
}
}
Hi,
If I click on the first link, I get a 404. Is this link correct?
From which version on the switch was done from Newtonsoft.Json to System.Text.Json? If I look at the release notes this was in 9.1. We are on 9.2.2.
We are using ASP.net Zero (Angular + ASP.Net) already for sometime and have build a custom application based on it. Until now our application is running on one server. Recently we have build a clustered environment where ASP.net is running on 2 servers behind a load-balancer. Both are running on the same database.
The issue happens when we first login as a host-admin. Then we select a tenant and login as that tenant. And then we logout again. The issue happens when the login-page (with tenant logo) opens again. Meanwhile we have built a workaround where we have developed a JsonConverter for ExternalLoginProviderInfo
I am sorry, I forgot I had to upgrade also other ABP packages.
The project should be in your inbox, Please let us know if you require additional information
The AuditExpansion attribute is used to provide extra context for certain properties in the UI.
On Application start-up, a dictionary is built based on these attributes, so the endpoint that fetches the data knows where to fetch context.
So if an entity has a UserId with a value of 5 that would be displayed as 5 (UserName)
That being said, The issue is happening without the attribute as well, and the duplicate properties are inserted in the DB on save, before we even attempt to fetch it for the front-end. at this point, no action has been taken yet due to the attribute
[AbpAuthorize(AppPermissions.Pages_Administration_Users_Edit)]
protected virtual async Task UpdateUserAsync(CreateOrUpdateUserInput input)
{
var user = await UserManager.FindByIdAsync(input.User.Id.Value.ToString());
//Update user properties
ObjectMapper.Map(input.User, user); //Passwords is not mapped (see mapping configuration)
CheckErrors(await UserManager.UpdateAsync(user));
if (input.SetRandomPassword)
{
var randomPassword = await _userManager.CreateRandomPassword();
user.Password = _passwordHasher.HashPassword(user, randomPassword);
input.User.Password = randomPassword;
}
else if (!input.User.Password.IsNullOrEmpty())
{
await UserManager.InitializeOptionsAsync(AbpSession.TenantId);
CheckErrors(await UserManager.ChangePasswordAsync(user, input.User.Password));
}
//Update roles
CheckErrors(await UserManager.SetRolesAsync(user, input.AssignedRoleNames));
//update organization units
await UserManager.SetOrganizationUnitsAsync(user, input.OrganizationUnits.ToArray());
if (AbpSession.TenantId.HasValue)
{
await _cacheManager.GetUserOrganizationUnitIdsRecursiveCache(AbpSession.GetTenantId()).ClearAsync();
await _cacheManager.GetUserOrganizationUnitIdsCache(AbpSession.GetTenantId()).ClearAsync();
await _cacheManager.GetUserOrganizationUnitsRecursiveCache(AbpSession.GetTenantId()).ClearAsync();
}
if (input.SendActivationEmail)
{
user.SetNewEmailConfirmationCode();
await _userEmailer.SendEmailActivationLinkAsync(
user,
AppUrlService.CreateEmailActivationUrlFormat(AbpSession.TenantId),
input.User.Password
);
}
}
UserManager custom implementations:
public override Task<IdentityResult> SetRolesAsync(User user, string[] roleNames)
{
if (user.Name == "admin" && !roleNames.Contains(StaticRoleNames.Host.Admin))
{
throw new UserFriendlyException(L("AdminRoleCannotRemoveFromAdminUser"));
}
return base.SetRolesAsync(user, roleNames);
}
[Audited]
[AuditExpansion(nameof(TenantId), typeof(Tenant), nameof(RmoniWeb.MultiTenancy.Tenant.Name))]
public class User : AbpUser<User>
{
public virtual Guid? ProfilePictureId { get; set; }
public virtual bool ShouldChangePasswordOnNextLogin { get; set; }
public DateTime? SignInTokenExpireTimeUtc { get; set; }
public string SignInToken { get; set; }
public string GoogleAuthenticatorKey { get; set; }
public List<ExtendedUserOrganizationUnit> OrganizationUnits { get; set; }
public ICollection<ReportUserRecipient> ReportUserRecipients { get; set; }
public ICollection<AlarmUserRecipient> AlarmUserRecipients { get; set; }
public ICollection<Device> MobileDevices { get; set; }
public bool IsRecipient { get; set; }
public Tenant Tenant { get; set; }
[ForeignKey("ApplicationLanguage")]
public int? LanguageId { get; set; }
public ApplicationLanguage ApplicationLanguage { get; set; }
//Can add application specific user properties here
public User()
{
IsLockoutEnabled = true;
IsTwoFactorEnabled = true;
}
public static User CreateTenantAdminUser(int tenantId, string emailAddress, string phoneNumber = default)
{
var user = new User
{
TenantId = tenantId,
UserName = AdminUserName,
Name = AdminUserName,
Surname = AdminUserName,
EmailAddress = emailAddress,
PhoneNumber = phoneNumber,
Roles = new List<UserRole>(),
OrganizationUnits = new List<ExtendedUserOrganizationUnit>()
};
user.SetNormalizedNames();
return user;
}
public override void SetNewPasswordResetCode()
{
PasswordResetCode = Guid.NewGuid().ToString("N").Truncate(10).ToUpperInvariant();
}
public void Unlock()
{
AccessFailedCount = 0;
LockoutEndDateUtc = null;
}
public void SetSignInToken()
{
SignInToken = Guid.NewGuid().ToString();
SignInTokenExpireTimeUtc = Clock.Now.AddMinutes(1).ToUniversalTime();
}
}
Hi @ismcagdas, if I follow https://github.com/aspnetzero/aspnet-zero-core/issues/4522#issuecomment-1215365279, I get a "Page Not Found Error". Can you provide the correct URL, please?