I have a background job that runs every 3 minutes:
using Abp.Dependency;
using Abp.Domain.Repositories;
using Abp.Domain.Uow;
using Abp.Threading.BackgroundWorkers;
using Abp.Threading.Timers;
using Force.MultiTenancy;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace Force.Api.Gemini
{
public class GeminiBackgroundWorker : PeriodicBackgroundWorkerBase, ISingletonDependency
{
private const int CheckPeriodAsMilliseconds = 1 * 60 * 3 * 1000; //3 minutes
private readonly IGeminiManager _geminiManager;
private readonly IRepository<Tenant> _tenantRepository;
public GeminiBackgroundWorker(
AbpTimer timer,
IGeminiManager geminiManager,
IRepository<Tenant> tenantRepository)
: base(timer)
{
_geminiManager = geminiManager;
_tenantRepository = tenantRepository;
Timer.RunOnStart = true;
Timer.Period = CheckPeriodAsMilliseconds;
}
protected override void DoWork()
{
Logger.Info("----GeminiBackgroundWorker.DoWork----------------");
_geminiManager.ProcessGeminiUpdates();
}
}
}
The first time it runs it gets the correct data from the database. Then, when it runs again, it doesn't get the newly update data. It seems to me that is using an out of date conext or something.
[UnitOfWork]
public virtual async Task ProcessGeminiUpdates()
{
try
{
Logger.Info("----GeminiManager.ProcessGemini-----------START-----");
var updatesNeeded = from o in _geminiUpdateRepository.GetAll()
join o1 in _wellLoadRepository.GetAll() on o.WellLoadId equals o1.Id into j1
from s1 in j1.DefaultIfEmpty()
join o2 in _customerRepository.GetAll() on s1.CustomerId equals o2.Id into j2
from s2 in j2.DefaultIfEmpty()
where
!o.Processed &&
s1.DispatchInitials == null &&
s2.GeminiEnabled && s2.GeminiPassword != null && s2.GeminiUsername != null && s2.GeminiClientSecret != null
select new GeminiAuthInputDto
{
CustomerId = s1.CustomerId.Value,
GeminiClientId = s2.GeminiClientId,
GeminiClientSecret = s2.GeminiClientSecret,
GeminiPassword = s2.GeminiPassword,
GeminiSubscriptionKey = s2.GeminiSubscriptionKey,
GeminiUsername = s2.GeminiUsername,
GeminiEnabled = s2.GeminiEnabled,
WellLoadId = s1.Id
};
var customers = await updatesNeeded.ToListAsync();
Logger.Info("----GeminiManager.ProcessGemini Customers -----------Count: " + customers.Count() + "-----");
if (customers != null && customers.Count > 0)
foreach (var customer in customers.GroupBy(x => x.CustomerId).Distinct())
{
Logger.Info("----GeminiManager.ProcessGemini FOREACH Customer-----------START-----");
var customerDto = customers.Where(x => x.CustomerId == customer.Key).FirstOrDefault();
var wellLoadsToProcess = customers.Where(x => x.CustomerId == customerDto.CustomerId).Select(x => x.WellLoadId).ToList();
await ProcessWellLoadsForCustomer(customerDto, wellLoadsToProcess);
Logger.Info("----GeminiManager.ProcessGemini FOREACH Customer-----------END-----");
}
Logger.Info("----GeminiManager.ProcessGemini-----------END-----");
}
catch (Exception e)
{
Logger.Info("----ProcessGeminiUpdates.Exception-----------" + e.Message + "-----");
}
}
What needs to be implemented to get the new data from the database every time it runs the background job?
We just got a few more duplicated with the above code implemented.
Will do! I will get this pushed out to our TESTING site now.
We cannot reproduce this either and have had more examples with different entities over the past week.
This is becoming a much larger issue since our client is looking for these now and is happening much more often than thought.
What should we look into next?
It would be very helpful if generating URLs for notifications was part of the documentation for the notification system. I've been digging through code for quite some time to then find out these are generated in the appUserNotificationHelper.js file.
Sure. I can try that, but I have never been able to recreate the issue to know for sure if your change will fix it. Do you find it strange that the AuditLog showed two entries for the CreateOrEdit call at the same EXACT Milisecond? A double click (even if we didn't block the UI) would show two different times for the AuditLog, agree?
I say this because these issues appear to be 1 in 10000.
(function ($) {
app.modals.CreateOrEditPurchaseOrderModal = function () {
var _purchaseOrdersService = abp.services.app.purchaseOrders;
var _modalManager;
var _$purchaseOrderInformationForm = null;
this.init = function (modalManager) {
_modalManager = modalManager;
var modal = _modalManager.getModal();
modal.find('.date-picker').datetimepicker({
locale: abp.localization.currentLanguage.name,
format: 'L'
});
initSearchPoTypesModal();
initSearchDivisionsModal();
initSearchEmployeesModal();
initSearchVendorsModal();
_$purchaseOrderInformationForm = _modalManager.getModal().find('form[name=PurchaseOrderInformationsForm]');
_$purchaseOrderInformationForm.validate();
};
this.save = function () {
if (!_$purchaseOrderInformationForm.valid()) {
return;
}
var purchaseOrder = _$purchaseOrderInformationForm.serializeFormToObject();
_modalManager.setBusy(true);
_purchaseOrdersService.createOrEdit(
purchaseOrder
).done(function () {
abp.notify.info(app.localize('SavedSuccessfully'));
_modalManager.close();
abp.event.trigger('app.createOrEditPurchaseOrderModalSaved');
}).always(function () {
_modalManager.setBusy(false);
});
};
};
})(jQuery);
@using System.Globalization
@using Force.Authorization
@using Force.Web.Areas.App.Models.Common.Modals
@using Force.Web.Areas.App.Models.PurchaseOrders
@using Abp.Application.Services.Dto
@model CreateOrEditPurchaseOrderModalViewModel
@Html.Partial("~/Areas/App/Views/Common/Modals/_ModalHeader.cshtml", new ModalHeaderViewModel(Model.IsEditMode ? (L("EditPurchaseOrder")) : L("CreateNewPurchaseOrder")))
<div class="modal-body">
<div id="PurchaseOrderInformationsTab">
<form name="PurchaseOrderInformationsForm" role="form" novalidate class="form-validation">
@if (Model.IsEditMode)
{
<input type="hidden" name="id" value="@Model.PurchaseOrder.Id" />
<input type="hidden" name="shopPurchaseOrderId" value="@Model.PurchaseOrder.ShopPurchaseOrderId" />
}
<div class="row">
<div class="col-md-6">
<div class="form-group m-form__group">
<label for="purchaseOrderTypeId">@L("PurchaseOrderType")</label>
<select name="purchaseOrderTypeId" id="purchaseOrderTypeId" class="search-potypes-select2-modal" data-width="100%" required>
@if (Model.PurchaseOrder.PurchaseOrderTypeId != 0)
{
<option value="@Model.PurchaseOrder.PurchaseOrderTypeId" selected="selected">@Model.PurchaseOrderTypeName</option>
}
</select>
</div>
</div>
<div class="col-md-6">
<div class="form-group m-form__group">
<label for="vendorId">@L("Vendor")</label>
<select name="vendorId" id="vendorId" class="search-vendors-select2-modal" data-width="100%" required>
@if (Model.PurchaseOrder.VendorId != 0)
{
<option value="@Model.PurchaseOrder.VendorId" selected="selected">@Model.VendorName</option>
}
</select>
</div>
</div>
</div>
<div class="row">
<div class="col-md-6">
<div class="form-group m-form__group">
<label for="organizationUnitId">@L("Division")</label>
<select name="organizationUnitId" id="organizationUnitId" class="search-divisions-select2-modal" data-width="100%" required>
@if (Model.PurchaseOrder.OrganizationUnitId != 0)
{
<option value="@Model.PurchaseOrder.OrganizationUnitId" selected="selected">@Model.OrganizationUnitDisplayName</option>
}
</select>
</div>
</div>
<div class="col-md-6">
<div class="form-group m-form__group">
<label for="employeeId">@L("Employee")</label>
<select name="employeeId" id="employeeId" class="search-employees-select2-modal" data-width="100%" required>
@if (Model.PurchaseOrder.EmployeeId != 0 && Model.EmployeeFirstName != null)
{
<option value="@Model.PurchaseOrder.EmployeeId" selected="selected">@Model.EmployeeFirstName</option>
}
</select>
</div>
</div>
</div>
<div class="row">
<div class="col-md-4">
<div class="form-group">
<label for="PurchaseOrder_OrderTime">@L("OrderTime")</label>
<input class="form-control m-input date-picker" id="PurchaseOrder_OrderTime" type="text" name="orderTime" value="@Model.PurchaseOrder.OrderTime" />
</div>
</div>
<div class="col-md-4">
<div class="form-group">
<label for="PurchaseOrder_PriceEstimate">@L("PriceEstimate")</label>
<input class="form-control m-input" id="PurchaseOrder_PriceEstimate" value="@Model.PurchaseOrder.PriceEstimate.ToString(CultureInfo.InvariantCulture)" type="number" name="priceEstimate" />
</div>
</div>
<div class="col-md-4">
<div class="form-group">
<label for="PurchaseOrder_Status">@L("Status")</label>
@Html.DropDownList("PurchaseOrderStatus", (SelectList)Model.PurchaseOrderStatusSelectList, null, new { @class = "form-control m-input select2me", required = "required" })
</div>
</div>
</div>
<div class="form-group">
<label for="PurchaseOrder_Description">@L("Description")</label>
<input class="form-control" id="PurchaseOrder_Description" value="@Model.PurchaseOrder.Description" type="text" name="description" required maxlength="@Force.PurchaseOrders.PurchaseOrderConsts.MaxDescriptionLength" minlength="@Force.PurchaseOrders.PurchaseOrderConsts.MinDescriptionLength" />
</div>
<div class="row">
<div class="col-md-3">
<div class="form-group">
<label for="PurchaseOrder_Quantity">@L("Quantity")</label>
<input class="form-control m-input" id="PurchaseOrder_Quantity" value="@Model.PurchaseOrder.Quantity?.ToString(CultureInfo.InvariantCulture)" type="number" name="quantity" />
</div>
</div>
<div class="col-md-3">
<div class="form-group">
<label for="PurchaseOrder_PriceEach">@L("PriceEach")</label>
<input class="form-control m-input" id="PurchaseOrder_PriceEach" value="@Model.PurchaseOrder.PriceEach?.ToString(CultureInfo.InvariantCulture)" type="number" name="priceEach" />
</div>
</div>
<div class="col-md-3">
<div class="form-group">
<label for="PurchaseOrder_TotalTax">@L("TotalTax")</label>
<input class="form-control m-input" id="PurchaseOrder_TotalTax" value="@Model.PurchaseOrder.TotalTax?.ToString(CultureInfo.InvariantCulture)" type="number" name="totalTax" />
</div>
</div>
<div class="col-md-3">
<div class="form-group">
<label for="PurchaseOrder_PriceTotal">@L("PriceTotal")</label>
<input class="form-control m-input" id="PurchaseOrder_PriceTotal" value="@Model.PurchaseOrder.PriceTotal?.ToString(CultureInfo.InvariantCulture)" type="number" name="priceTotal" />
</div>
</div>
</div>
<div class="row">
<div class="col-md-6">
<div class="form-group">
<label for="PurchaseOrder_JobField">@L("JobField")</label>
<input class="form-control m-input" id="PurchaseOrder_JobField" value="@Model.PurchaseOrder.JobField" type="text" name="jobField" />
</div>
</div>
<div class="col-md-6">
<div class="form-group">
<label for="poAccountId">@L("AccountNumber")</label>
@Html.DropDownList("poAccountId", Model.PoAccountItems.Select(i => i.ToSelectListItem()), new { @class = "form-control select2me" })
</div>
</div>
</div>
<div class="form-group">
<label for="PurchaseOrder_Notes">@L("Notes")</label>
@Html.TextArea("Notes", Model.PurchaseOrder.Notes, 4, 1, new { @class = "form-control" })
</div>
</form>
</div>
</div>
@if (Model.PurchaseOrder.PurchaseOrderStatus != 3 || IsGranted(AppPermissions.Entities_PurchaseOrders_EditClosed))
{
@Html.Partial("~/Areas/App/Views/Common/Modals/_ModalFooterWithSaveAndCancel.cshtml")
}
else
{
@Html.Partial("~/Areas/App/Views/Common/Modals/_ModalFooterWithClose.cshtml")
}
@ismcagdas What are your thoughts on the AppService being called twice (same millisecond) with two different requests? As in, the ModalManager blocked the UI but somehow called the AppService twice.
Thanks for the response @ismcagdas!
It appears the AuditLogs shows the Service being called twice at the same time. We're using the standard CreateOrEditModal to call the AppService from JS.
The following issue happens about once every 6-8 weeks. Not always the same user.
I used the Rad Tool to create AppServices etc. with the standard Create function below, somehow an the App Service is inserting TWO rows with the exact same data (exepct the PK Id (int) field).
I've added to the create code to use a Tenant Specific Sequential ID, that increments and stores the value in a table.
[AbpAuthorize(AppPermissions.Entities_PurchaseOrders_Create)]
private async Task Create(CreateOrEditPurchaseOrderDto input)
{
var purchaseOrder = ObjectMapper.Map<PurchaseOrder>(input);
if (AbpSession.TenantId != null)
{
purchaseOrder.TenantId = (int)AbpSession.TenantId;
}
purchaseOrder.SequentialId = await _sequenceManager.GetPurchaseOrderSequence();
if (input.PurchaseOrderStatus == (int)PurchaseOrderStatus.Closed)
purchaseOrder.ClosedByUserId = AbpSession.UserId;
await _purchaseOrderRepository.InsertAsync(purchaseOrder);
}
SequenceManager below handles 9 other tables and AppServices that have this Tenant specific SequentialId.
public async Task<int> GetPurchaseOrderSequence()
{
return await GetSequence(_purchaseOrderSequence);
}
private async Task<int> GetSequence(string sequenceEntity)
{
using (_unitOfWorkManager.Current.SetTenantId(AbpSession.TenantId.Value))
{
var sequence = await _repository.FirstOrDefaultAsync(x => x.Entity == sequenceEntity);
if (sequence == null)
sequence = new SequentialId() { Entity = sequenceEntity, Sequence = 1 };
else
sequence.Sequence = sequence.Sequence + 1;
await _repository.InsertOrUpdateAsync(sequence);
await _unitOfWorkManager.Current.SaveChangesAsync();
return sequence.Sequence;
}
}
The SequenceManager is NOT decorated with any UnitOfWork attributes or anything like that.
Can anyone help me solve this issue that has been plaguing the app for the last year or so? EDIT: I can never recreate the issue (trying to double click the Create Modal etc.)