Cannot provision Microsoft account without Last Name #10637

3 Answer(s)

• 

  0

  ismcagdas created 3 years ago

  Support Team

  Hi @hra

  I have created an issue about this, see https://github.com/aspnetzero/aspnet-zero-core/issues/4064.

  As a workaround, you can use the source code of MicrosoftAuthProviderApi as shown below and handle surname being null.

  using System;
  using System.Collections.Generic;
  using System.Net.Http;
  using System.Net.Http.Headers;
  using System.Threading.Tasks;
  using Microsoft.AspNetCore.Authentication.MicrosoftAccount;
  using Newtonsoft.Json.Linq;
  
  namespace Abp.AspNetZeroCore.Web.Authentication.External.Microsoft
  {
      public class MicrosoftAuthProviderApi : ExternalAuthProviderApiBase
      {
          public const string Name = "Microsoft";
  
          public async override Task<ExternalAuthUserInfo> GetUserInfo(string accessCode)
          {
              /* TODO: Microsoft login could not be tested because of a problem on Angular2 application.
               * see login.service.ts in Angular2 application.
               * This is not a problem for MVC application since it uses server side login.
               */
  
              using (var client = new HttpClient())
              {
                  client.DefaultRequestHeaders.UserAgent.ParseAdd("Microsoft ASP.NET Core OAuth middleware");
                  client.DefaultRequestHeaders.Accept.ParseAdd("application/json");
                  client.Timeout = TimeSpan.FromSeconds(30);
                  client.MaxResponseContentBufferSize = 1024 * 1024 * 10; // 10 MB
  
                  var request = new HttpRequestMessage(HttpMethod.Get, MicrosoftAccountDefaults.UserInformationEndpoint);
                  request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", accessCode);
  
                  var response = await client.SendAsync(request);
  
                  response.EnsureSuccessStatusCode();
  
                  var payload = JObject.Parse(await response.Content.ReadAsStringAsync());
  
                  var result = new ExternalAuthUserInfo
                  {
                      Name = MicrosoftAccountHelper.GetDisplayName(payload),
                      EmailAddress = MicrosoftAccountHelper.GetEmail(payload),
                      Surname = MicrosoftAccountHelper.GetSurname(payload),
                      Provider = Name,
                      ProviderKey = MicrosoftAccountHelper.GetId(payload)
                  };
  
                  FillClaimsFromJObject(result, payload);
                  return result;
              }
          }
      }
  }
  

  Save Cancel
• 

  0

  hra created 3 years ago

  A supplement to @ismcagdas's workaround - he's also supplied some additional code - thanks:

  protected virtual void FillClaimsFromJObject(ExternalAuthUserInfo userInfo, JObject payload) { var dict = new Dictionary<string, string>(); foreach (var item in payload) { dict.Add(item.Key,item.Value?.ToString()); } userInfo.Claims = dict; }

  You can use the class MicrosoftAuthProviderApi in the TokenAuthController's (for angular project) ExternalAuthenticate method. Just check for (input.AuthProvider == "Microsoft") and if it is true, create a new instance of MicrosoftAuthProviderApi and get the user info from your custom class.

  If you are using the MVC version of AspNet Zero, you can do it in AccountController.

  Save Cancel
• 

  0

  ismcagdas created 3 years ago

  Support Team

  Hi @hra

  Thanks, but it seems like this doesn't work as well because the setter for userInfo.Claims is private. We will try to release a patch version for related NuGet packages soon.

  Save Cancel