Release 6.2.0 has the same logo names created in many components:
root.module.ts metaImage.setAttribute('content', window.location.origin + '/assets/common/images/app-logo-on-' + ui.getAsideSkin() + '.svg');
invoice.components.ts companyLogo = AppConsts.appBaseUrl + '/assets/common/images/logo.svg';
topbar.component.ts defaultLogo = AppConsts.appBaseUrl + '/assets/common/images/app-logo-on-' + this.ui.getAsideSkin() + '.svg';
UserNotificationHelper.ts icon: abp.appPath + 'assets/common/images/app-logo-small.svg',
default-brand.component.ts defaultLogo = AppConsts.appBaseUrl + '/assets/common/images/app-logo-on-' + this.ui.getAsideSkin() + '.svg';
I want to use .png file types in my app. Instead of having to change 5 files every upgrade cycle, it would be easier if all the logo names were consolidated in a single file.
3 Answer(s)
-
0
Hi @timmackey
- app-logo-on-dark.svg
- app-logo-on-light.svg
files are necessary for using black/white page headers and they are also necessary for some themes because some of Metronic themes uses 2 different logos.
app-logo-small.svg is necessary for showing a browser notification to user when user got a notification.
We can replace logo.svg with app-logo-on-dark.svg or app-logo-on-light.svg (I'm not sure which one is the correct one for now) but there will be still 3 logos instead of 4.
-
0
The number of logo files is not important. I'm requesting that the filenames be defined in the same file somewhere. Locating items that are likely to be customized to a single location would be preferrable to scattering them across the system.
I've expended considerable effort designing my customized implementation of ANZ to minimize the impact of merging upgrades. Please consider what your customers may encounter for every upgrade cycle. Thank you.
-
0
@timmackey This can be added to documentation, I have created an issue for this purpose https://github.com/aspnetzero/documents/issues/110
